feat: Improved collaboration cursor UX #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
Jan 16, 2025
- Cleaned up code - Added visibility dot to cursors - Added animations
YousefED
reviewed
Jan 16, 2025
| label.classList.add("collaboration-cursor__label"); | ||
| label.setAttribute("style", `background-color: ${user.color}`); | ||
| label.insertBefore(document.createTextNode(user.name), null); | ||
| cursorElement.addEventListener("mouseenter", () => { |
There was a problem hiding this comment.
is this needed or can we just use css :hover?
There was a problem hiding this comment.
I think we still want it - GDocs behaviour still has a delay for hiding after moving the mouse off the cursor. We could have a CSS transition delay instead but it's added complexity in both cases so this is ok imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the collaboration cursor UX so that the name tag no longer annoyingly blocks user text selection. The UX changes are summarized here: #1163 (comment).
Closes #1163